Skip to content

Add fixed strings for the difficulty tag [PC-938] #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 2, 2022
Merged

Add fixed strings for the difficulty tag [PC-938] #294

merged 4 commits into from
Sep 2, 2022

Conversation

marqdevx
Copy link
Member

What This PR Changes

  • The Linter tool now will only accept the following difficulty tags: Easy, Intermediate, Advanced

@marqdevx marqdevx added enhancement New feature or request arduino Bugs and fixes added by the Arduino Team labels Jun 14, 2022
@marqdevx marqdevx self-assigned this Jun 14, 2022
@marqdevx marqdevx requested a review from sebromero June 14, 2022 13:49
@marqdevx
Copy link
Member Author

It would be nice to get first what is happening here #293

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 14, 2022 •
edited
Loading

Gatsby Cloud Build Report

docs-content

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 3m

sebromero
sebromero previously requested changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pablo! Please have a look at my comment.

@marqdevx
Copy link
Member Author

I will make the needed changes on the other PR, and then merge it here
#293 into #294

@marqdevx marqdevx force-pushed the marqdevx/linter/difficulty-tags branch from f548932 to 16d2ac3 Compare September 2, 2022 10:00
@marqdevx marqdevx requested a review from sebromero September 2, 2022 10:22
@marqdevx marqdevx dismissed sebromero’s stale review September 2, 2022 10:22

Changes addressed

sebromero
sebromero approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marqdevx marqdevx merged commit e91ad20 into main Sep 2, 2022
@marqdevx marqdevx deleted the marqdevx/linter/difficulty-tags branch September 2, 2022 10:34
Serjlee pushed a commit that referenced this pull request Jan 16, 2023
@jcarolinares
Merge pull request #294 from arduino/canchebagur/opta-rs485-tutorial-fix
75b3667 
[PC-1075] Opta RS-485 tutorial review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlsoderby karlsoderby karlsoderby left review comments

@sebromero sebromero sebromero approved these changes

Assignees

@marqdevx marqdevx

Labels
arduino Bugs and fixes added by the Arduino Team enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marqdevx @sebromero @karlsoderby